sanpwc commented on code in PR #3092:
URL: https://github.com/apache/ignite-3/pull/3092#discussion_r1475969285


##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java:
##########
@@ -1944,7 +1944,7 @@ private <T> CompletableFuture<T> appendTxCommand(UUID 
txId, RequestType cmdType,
         });
 
         if (cleanupReadyFut.isCompletedExceptionally()) {
-            return failedFuture(new 
TransactionException(TX_FAILED_READ_WRITE_OPERATION_ERR, "Transaction is 
already finished."));
+            return failedFuture(new 
TransactionException(TX_ALREADY_FINISHED_ERR, "Transaction is already 
finished."));

Review Comment:
   Is that true? Does it really means that if cleanupReadyFut was completed 
exceptionally then transaction was already finished?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to