ibessonov commented on code in PR #3090: URL: https://github.com/apache/ignite-3/pull/3090#discussion_r1479624080
########## modules/failure-handler/src/main/java/org/apache/ignite/internal/failure/FailureContext.java: ########## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.failure; + +import org.apache.ignite.internal.tostring.S; + +/** + * Failure context contains information about failure type and exception if applicable. + * This information could be used for appropriate handling of the failure. + */ +public class FailureContext { + /** Type. */ + private final FailureType type; + + /** Error. */ + private final Throwable err; + + /** + * Creates instance of {@link FailureContext}. + * + * @param type Failure type. + * @param err Exception. + */ + public FailureContext(FailureType type, Throwable err) { + this.type = type; + this.err = err; + } + + /** + * Gets the failure type. Review Comment: Can I ask you to replace all these ridiculous "gets" with "returns"? I understand that it's a copy of a pre-existing class, but it looks weird nonetheless. ########## modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/checkpoint/CheckpointReadLockTimeoutException.java: ########## @@ -32,6 +33,6 @@ public class CheckpointReadLockTimeoutException extends IgniteInternalException * @param msg Error message. */ CheckpointReadLockTimeoutException(String msg) { - super(msg); + super(SYSTEM_CRITICAL_OPERATION_TIMEOUT_ERR, msg); Review Comment: Not sure about that, to be honest, but better safe than sorry, right? ########## modules/runner/src/main/java/org/apache/ignite/internal/app/IgniteImpl.java: ########## @@ -390,11 +394,15 @@ public class IgniteImpl implements Ignite { MessageSerializationRegistry serializationRegistry = createSerializationRegistry(serviceProviderClassLoader); + // TODO https://issues.apache.org/jira/browse/IGNITE-20450 + failureProcessor = new FailureProcessor(name); Review Comment: Who's calling `start` and `stop` for this component? Is this done automatically? ########## modules/failure-handler/src/main/java/org/apache/ignite/internal/failure/handlers/StopNodeOrHaltFailureHandler.java: ########## @@ -0,0 +1,118 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.failure.handlers; + +import java.util.concurrent.CountDownLatch; +import java.util.concurrent.TimeUnit; +import org.apache.ignite.IgnitionManager; +import org.apache.ignite.internal.failure.FailureContext; +import org.apache.ignite.internal.tostring.S; + +/** + * Handler will try to stop node if {@code tryStop} value is {@code true}. + * If node can't be stopped during provided {@code timeout} or {@code tryStop} value is {@code false} + * then JVM process will be terminated forcibly using {@code Runtime.getRuntime().halt()}. + */ +public class StopNodeOrHaltFailureHandler implements FailureHandler { + /** + * This is kill code that can be used by external tools, like Shell scripts, + * to auto-stop the Ignite JVM process without restarting. + */ + private static final int KILL_EXIT_CODE = 130; + + /** Try stop. */ + private final boolean tryStop; + + /** Timeout in milliseconds. */ + private final long timeout; + + /** + * Creates a new instance of a failure processor. + */ + public StopNodeOrHaltFailureHandler() { + this(false, 0); + } + + /** + * Creates a new instance of a failure processor. + * + * @param tryStop Try stop. + * @param timeout Stop node timeout in milliseconds. + */ + public StopNodeOrHaltFailureHandler(boolean tryStop, long timeout) { + this.tryStop = tryStop; + this.timeout = timeout; + } + + /** {@inheritDoc} */ + @Override + public boolean onFailure(String nodeName, FailureContext failureCtx) { + if (tryStop) { + CountDownLatch latch = new CountDownLatch(1); + + new Thread( + () -> { + IgnitionManager.stop(nodeName); + + latch.countDown(); + }, + "node-stopper" + ).start(); + + new Thread( + () -> { + try { + if (!latch.await(timeout, TimeUnit.MILLISECONDS)) { + Runtime.getRuntime().halt(KILL_EXIT_CODE); + } + } catch (InterruptedException e) { + // No-op. + } + }, + "jvm-halt-on-stop-timeout" + ).start(); + } else { + Runtime.getRuntime().halt(KILL_EXIT_CODE); + } + + return true; + } + + /** + * Get stop node timeout in milliseconds. Review Comment: Please correct these javadocs as well ########## modules/failure-handler/src/main/java/org/apache/ignite/internal/failure/FailureContext.java: ########## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.failure; + +import org.apache.ignite.internal.tostring.S; + +/** + * Failure context contains information about failure type and exception if applicable. + * This information could be used for appropriate handling of the failure. + */ +public class FailureContext { + /** Type. */ + private final FailureType type; + + /** Error. */ + private final Throwable err; + + /** + * Creates instance of {@link FailureContext}. + * + * @param type Failure type. + * @param err Exception. + */ + public FailureContext(FailureType type, Throwable err) { + this.type = type; + this.err = err; + } + + /** + * Gets the failure type. + * + * @return Failure type. + */ + public FailureType type() { + return type; + } + + /** + * Gets the exception. + * + * @return Exception or {@code null}. + */ + public Throwable error() { + return err; + } + + /** {@inheritDoc} */ Review Comment: This is also not necessary, but I don't mind it ########## modules/api/src/main/java/org/apache/ignite/lang/ErrorGroups.java: ########## @@ -580,4 +580,17 @@ public static class PlacementDriver { /** Primary replica await error. */ public static final int PRIMARY_REPLICA_AWAIT_ERR = PLACEMENT_DRIVER_ERR_GROUP.registerErrorCode((short) 2); } + + /** Critical workers error group. */ + @ErrorCodeGroup + public static class CriticalWorkers { Review Comment: How is this a public API? ########## modules/failure-handler/src/test/java/org/apache/ignite/internal/failure/FailureProcessorTest.java: ########## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.failure; + +import static org.apache.ignite.internal.testframework.matchers.CompletableFutureMatcher.willSucceedFast; +import static org.hamcrest.MatcherAssert.assertThat; +import static org.mockito.ArgumentMatchers.any; +import static org.mockito.ArgumentMatchers.anyString; +import static org.mockito.Mockito.mock; +import static org.mockito.Mockito.times; +import static org.mockito.Mockito.verify; + +import org.apache.ignite.internal.failure.handlers.FailureHandler; +import org.apache.ignite.internal.testframework.BaseIgniteAbstractTest; +import org.junit.jupiter.api.Test; + +/** + * Tests for {@link FailureProcessor}. + */ +class FailureProcessorTest extends BaseIgniteAbstractTest { + @Test + void testFailureProcessing() { + FailureHandler handler = mock(FailureHandler.class); + + FailureProcessor failureProcessor = new FailureProcessor("node_name", handler); + + assertThat(failureProcessor.start(), willSucceedFast()); + + try { + Review Comment: ```suggestion ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
