alex-plekhanov commented on code in PR #11176:
URL: https://github.com/apache/ignite/pull/11176#discussion_r1481654647
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/platform/client/cache/ClientCacheKeyRequest.java:
##########
@@ -47,6 +50,28 @@ public abstract class ClientCacheKeyRequest extends
ClientCacheDataRequest imple
/** {@inheritDoc} */
@Override public final ClientResponse process(ClientConnectionContext ctx)
{
+ updateMetrics(ctx);
+
+ // Process request in overriden method.
+ return process0(ctx);
+ }
+
+ /** {@inheritDoc} */
+ @Override public final IgniteInternalFuture<ClientResponse>
processAsync(ClientConnectionContext ctx) {
+ updateMetrics(ctx);
+
+ // Process request in overriden method.
+ return processAsync0(ctx);
+ }
+
+ /** {@inheritDoc} */
+ @Override public boolean isAsync(ClientConnectionContext ctx) {
+ // Every cache data request on the transactional cache can lock the
thread, even with implicit transaction.
+ return cacheDescriptor(ctx).cacheConfiguration().getAtomicityMode() ==
CacheAtomicityMode.TRANSACTIONAL;
Review Comment:
Unfortunately, implicit operations also can block the thread. So, ignore my
last proposal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
