tkalkirill commented on code in PR #3181:
URL: https://github.com/apache/ignite-3/pull/3181#discussion_r1482447211
##########
modules/runner/src/main/java/org/apache/ignite/internal/configuration/storage/LocalFileConfigurationStorage.java:
##########
@@ -104,11 +103,26 @@ public class LocalFileConfigurationStorage implements
ConfigurationStorage {
* @param configPath Path to node bootstrap configuration file.
* @param generator Configuration tree generator.
*/
+ @TestOnly
public LocalFileConfigurationStorage(Path configPath,
ConfigurationTreeGenerator generator) {
+ this("test", configPath, generator);
+ }
+
+ /**
+ * Constructor.
+ *
+ * @param configPath Path to node bootstrap configuration file.
+ * @param generator Configuration tree generator.
+ */
+ public LocalFileConfigurationStorage(String nodeName, Path configPath,
ConfigurationTreeGenerator generator) {
this.configPath = configPath;
this.generator = generator;
this.tempConfigPath =
configPath.resolveSibling(configPath.getFileName() + ".tmp");
+ notificationsThreadPool = Executors.newFixedThreadPool(
Review Comment:
Just a curious question, why two threads...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
