sanpwc commented on code in PR #3200:
URL: https://github.com/apache/ignite-3/pull/3200#discussion_r1489284542
##########
modules/table/src/integrationTest/java/org/apache/ignite/distributed/ItInternalTableReadOnlyScanTest.java:
##########
@@ -33,15 +36,30 @@
*/
@ExtendWith(MockitoExtension.class)
public class ItInternalTableReadOnlyScanTest extends
ItAbstractInternalTableScanTest {
+ private static final HybridTimestampTracker HYBRID_TIMESTAMP_TRACKER = new
HybridTimestampTracker();
+
@Override
protected Publisher<BinaryRow> scan(int part, InternalTransaction tx) {
- return internalTbl.scan(part, internalTbl.CLOCK.now(),
mock(ClusterNode.class));
+ requireNonNull(tx);
+
+ return internalTbl.scan(part, tx.id(), internalTbl.CLOCK.now(),
mock(ClusterNode.class));
}
// TODO: IGNITE-17666 Use super test as is.
@Disabled("https://issues.apache.org/jira/browse/IGNITE-17666";)
@Override
+ @Test
public void testExceptionRowScanCursorHasNext() throws Exception {
super.testExceptionRowScanCursorHasNext();
}
+
+ @Override
+ protected InternalTransaction startTx() {
+ return internalTbl.txManager().begin(HYBRID_TIMESTAMP_TRACKER, true);
Review Comment:
Does it mean that we won't test implicit RO? Why?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
