denis-chudov commented on code in PR #3206:
URL: https://github.com/apache/ignite-3/pull/3206#discussion_r1490551416
##########
modules/placement-driver/src/integrationTest/java/org/apache/ignite/internal/placementdriver/ActiveActorTest.java:
##########
@@ -193,453 +144,22 @@ private boolean checkSingleActiveActor(String
leaderName) {
return true;
}
- @Test
- public void testOneNodeReplicationGroup(TestInfo testInfo) throws
Exception {
- var clusterServices = new HashMap<NetworkAddress, ClusterService>();
- var raftServers = new HashMap<NetworkAddress, JraftServerImpl>();
- int nodes = 2;
-
- TopologyAwareRaftGroupService raftClient = startCluster(
- testInfo,
- clusterServices,
- raftServers,
- addr -> true,
- nodes,
- PORT_BASE + 1
- );
-
- CompletableFuture<ClusterNode> leaderFut = new CompletableFuture<>();
-
- raftClient.subscribeLeader((node, term) -> leaderFut.complete(node));
-
- ClusterNode leader = leaderFut.get(10, TimeUnit.SECONDS);
-
- assertNotNull(leader);
-
- afterInitCheckConditionWithWait(leader.name());
-
- stopCluster(clusterServices, raftServers, List.of(raftClient), nodes);
- }
-
- @Test
- public void testChangeLeaderWhenActualLeft(TestInfo testInfo) throws
Exception {
- var clusterServices = new HashMap<NetworkAddress, ClusterService>();
- var raftServers = new HashMap<NetworkAddress, JraftServerImpl>();
- int nodes = 3;
- Predicate<NetworkAddress> isServerAddress = addr -> true;
-
- TopologyAwareRaftGroupService raftClient = startCluster(
- testInfo,
- clusterServices,
- raftServers,
- isServerAddress,
- nodes,
- PORT_BASE
- );
-
- raftClient.refreshLeader().get();
-
- var clientClusterService = clusterService(testInfo, PORT_BASE + nodes
+ 1, new StaticNodeFinder(getNetworkAddresses(nodes)));
- clientClusterService.start();
-
- TopologyAwareRaftGroupService raftClientNoInitialNotify =
startTopologyAwareClient(
- clientClusterService,
- clusterServices,
- isServerAddress,
- nodes,
- null,
- false
- );
-
- AtomicReference<ClusterNode> leaderRef = new AtomicReference<>();
- AtomicReference<ClusterNode> leaderRefNoInitialNotify = new
AtomicReference<>();
- AtomicInteger callsCount = new AtomicInteger();
-
- raftClient.subscribeLeader((node, term) -> leaderRef.set(node));
-
- for (int i = 0; i < 2; i++) {
- raftClientNoInitialNotify.unsubscribeLeader();
-
- raftClientNoInitialNotify.subscribeLeader((node, term) -> {
- callsCount.incrementAndGet();
- leaderRefNoInitialNotify.set(node);
- });
- }
-
- assertTrue(callsCount.get() <= 1);
-
- assertTrue(waitForCondition(() -> leaderRef.get() != null, 10_000));
-
- ClusterNode leader = leaderRef.get();
-
- assertNotNull(leader);
-
- log.info("Leader: " + leader);
-
- afterInitCheckConditionWithWait(leader.name());
-
- var raftServiceToStop = raftServers.remove(new
NetworkAddress("localhost", leader.address().port()));
- raftServiceToStop.stopRaftNodes(GROUP_ID);
- raftServiceToStop.stop();
-
- afterNodeStop(leader.name());
-
- clusterServices.remove(new NetworkAddress("localhost",
leader.address().port())).stop();
-
- assertTrue(waitForCondition(() -> !leader.equals(leaderRef.get()),
10_000));
- assertTrue(waitForCondition(() ->
!leader.equals(leaderRefNoInitialNotify.get()), 1000));
-
- log.info("New Leader: " + leaderRef.get());
-
- afterLeaderChangeCheckConditionWithWait(leaderRef.get().name());
-
- raftClientNoInitialNotify.refreshLeader().get();
-
- assertEquals(raftClientNoInitialNotify.leader().consistentId(),
leaderRef.get().name());
-
- stopCluster(clusterServices, raftServers, List.of(raftClient,
raftClientNoInitialNotify), nodes);
-
- clientClusterService.stop();
- }
-
- @Test
- @Disabled("https://issues.apache.org/jira/browse/IGNITE-21381";)
- public void testChangeLeaderForce(TestInfo testInfo) throws Exception {
- var clusterServices = new HashMap<NetworkAddress, ClusterService>();
- var raftServers = new HashMap<NetworkAddress, JraftServerImpl>();
- int nodes = 3;
- Predicate<NetworkAddress> isServerAddress = addr -> true;
-
- TopologyAwareRaftGroupService raftClient = startCluster(
- testInfo,
- clusterServices,
- raftServers,
- isServerAddress,
- nodes,
- PORT_BASE
- );
-
- raftClient.refreshLeader().get();
-
- var clientClusterService = clusterService(testInfo, PORT_BASE + nodes
+ 1, new StaticNodeFinder(getNetworkAddresses(nodes)));
- clientClusterService.start();
-
- TopologyAwareRaftGroupService raftClientNoInitialNotify =
startTopologyAwareClient(
- clientClusterService,
- clusterServices,
- isServerAddress,
- nodes,
- null,
- false
- );
-
- AtomicReference<ClusterNode> leaderRef = new AtomicReference<>();
- AtomicReference<ClusterNode> leaderRefNoInitialNotify = new
AtomicReference<>();
- AtomicInteger callsCount = new AtomicInteger();
-
- raftClient.subscribeLeader((node, term) -> leaderRef.set(node));
-
- for (int i = 0; i < 2; i++) {
- raftClientNoInitialNotify.unsubscribeLeader();
-
- raftClientNoInitialNotify.subscribeLeader((node, term) -> {
- callsCount.incrementAndGet();
- leaderRefNoInitialNotify.set(node);
- });
- }
-
- assertTrue(callsCount.get() <= 1);
-
- assertTrue(waitForCondition(() -> leaderRef.get() != null, 10_000));
-
- ClusterNode leader = leaderRef.get();
-
- assertNotNull(leader);
-
- log.info("Leader: " + leader);
-
- afterInitCheckConditionWithWait(leader.name());
-
- Peer newLeaderPeer = raftClient.peers().stream().filter(peer ->
!leader.name().equals(peer.consistentId())).findAny().get();
-
- log.info("Peer to transfer leader: " + newLeaderPeer);
-
- raftClient.transferLeadership(newLeaderPeer).get();
-
- String leaderId = newLeaderPeer.consistentId();
-
- assertTrue(waitForCondition(() ->
leaderId.equals(leaderRef.get().name()), 10_000));
- assertTrue(waitForCondition(
- () -> leaderRefNoInitialNotify.get() != null &&
leaderId.equals(leaderRefNoInitialNotify.get().name()), 1000)
- );
-
- log.info("New Leader: " + leaderRef.get());
-
- afterLeaderChangeCheckConditionWithWait(leaderRef.get().name());
-
- raftClient.refreshLeader().get();
-
- assertEquals(raftClient.leader().consistentId(),
leaderRef.get().name());
-
- stopCluster(clusterServices, raftServers, List.of(raftClient,
raftClientNoInitialNotify), nodes);
- clientClusterService.stop();
+ @Override
+ protected void afterClusterInit(String leaderName) throws
InterruptedException {
+ assertTrue(waitForCondition(() -> checkSingleActiveActor(leaderName),
10_000));
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
