lowka commented on code in PR #3187:
URL: https://github.com/apache/ignite-3/pull/3187#discussion_r1491071264
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/mapping/MappingServiceImpl.java:
##########
@@ -147,7 +152,7 @@ private CompletableFuture<List<MappedFragment>>
map0(MultiStepPlan multiStepPlan
return val;
});
- return cacheValue.mappedFragments;
+ return cacheValue.mappedFragments.thenApply(mappedFragments ->
applyPartitionPruning(mappedFragments, parameters));
Review Comment:
I think when a query has no dynamic parameters, when can apply partition
pruning to before adding fragments to cache.
And if there are dynamic parameters, we should apply partition pruning after
retrieving fragments from the cache.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
