rpuch commented on code in PR #3216:
URL: https://github.com/apache/ignite-3/pull/3216#discussion_r1491089525
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java:
##########
@@ -3795,7 +3795,7 @@ private CompletableFuture<Boolean>
onIndexBuilding(CatalogEventParameters parame
assert indexDescriptor != null : "indexId=" + indexId + ",
catalogVersion=" + parameters.catalogVersion();
if (indexDescriptor.tableId() == tableId()) {
-
txRwOperationTracker.updateMinAllowedCatalogVersionForStartOperation(indexDescriptor.creationCatalogVersion());
+
txRwOperationTracker.updateMinAllowedCatalogVersionForStartOperation(indexDescriptor.txWaitCatalogVersion());
Review Comment:
Even if some operation from a dead coordinator executes, it's not a problem:
the worst thing it can do is add a tuple to an index that is not writable
anymore, it's not a big deal. We can ignore this for the sake of code
simplicity.
Also, if we raise minAllowedVersion here, we won't allow to execute an
operation from a dead coordinator that we could allow to execute.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
