rpuch commented on code in PR #3215: URL: https://github.com/apache/ignite-3/pull/3215#discussion_r1492486145
########## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/snapshot/ReadOnlyIndexInfo.java: ########## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.table.distributed.raft.snapshot; + +import org.apache.ignite.internal.tostring.S; + +/** Internal class for use in {@link FullStateTransferIndexChooser} for read-only indexes. */ +final class ReadOnlyIndexInfo implements Comparable<ReadOnlyIndexInfo> { + private final int tableId; + + private final long activationTs; Review Comment: Well, the name I suggested is bad, as it's about the start of either stopping or readonly. But the current name makes you think that it's *always* about READONLY, which is not true as well. How about `dropActivationTs` with a javadoc explaining that it's the ts of the state following the AVAILABLE state? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
