ibessonov commented on code in PR #3226:
URL: https://github.com/apache/ignite-3/pull/3226#discussion_r1494376686
##########
modules/placement-driver/src/main/java/org/apache/ignite/internal/placementdriver/AssignmentsTracker.java:
##########
@@ -97,7 +97,7 @@ public void startTrack() {
TablePartitionId grpId =
TablePartitionId.fromString(strKey);
- Set<Assignment> assignments =
ByteUtils.fromBytes(entry.value());
+ Set<Assignment> assignments =
Assignments.fromBytes(entry.value()).nodes();
groupAssignments.put(grpId, assignments);
Review Comment:
I'm planning to add meta-information to the Assignments class that won't be
required for tracking. So this class is only for storage and communication
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -2153,24 +2154,27 @@ protected CompletableFuture<Void>
handleChangeStableAssignmentEvent(
TablePartitionId tablePartitionId = new TablePartitionId(tableId,
partitionId);
- Set<Assignment> stableAssignments =
ByteUtils.fromBytes(stableAssignmentsWatchEvent.value());
+ return supplyAsync(() -> {
+ Set<Assignment> stableAssignments =
stableAssignmentsWatchEvent.value() == null
Review Comment:
Yes, I'll do it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
