valepakh commented on code in PR #3191:
URL: https://github.com/apache/ignite-3/pull/3191#discussion_r1494441869


##########
modules/compute/src/integrationTest/java/org/apache/ignite/internal/compute/utils/InteractiveJobs.java:
##########
@@ -180,6 +192,24 @@ public String execute(JobExecutionContext context, 
Object... args) {
                 RUNNING_INTERACTIVE_JOBS_CNT.decrementAndGet();
             }
         }
+
+        /**
+         * If any of the args are strings, convert them to signals and offer 
them to the job.
+         *
+         * @param args Job args.
+         */
+        private static void offerArgsAsSignals(Object[] args) {

Review Comment:
   > Why not just send a signal from the test? Why should we pass signals to 
the job and this job will set signals to itself???
   
   Because we're testing a synchronous methods.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to