korlov42 commented on PR #3222: URL: https://github.com/apache/ignite-3/pull/3222#issuecomment-1953613134
Nothing actually has changed since my last review: this patch introduces second implementation of CAST operator, the latter still has discrepancies with the first implementation (for example, you can't use 'true' for boolean column in DDL, but it works like a charm in `SELECT 'true'::BOOLEAN`). I see two possible way to approach the issue: 1. we leave second implementation as proposed, but add decent test coverage which will for every possible types pair compare outcome of conversion in DDL with conversion in regular SELECT 2. we make conversion in DDL and SELECT share _the same_ code path Personally, I prefer the second option. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
