korlov42 commented on code in PR #3170:
URL: https://github.com/apache/ignite-3/pull/3170#discussion_r1497046172
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExecutableTableRegistryImpl.java:
##########
@@ -74,15 +74,13 @@ public CompletableFuture<ExecutableTable> getTable(int
schemaVersion, int tableI
return tableCache.computeIfAbsent(cacheKey(tableId,
sqlTable.version()), (k) -> loadTable(sqlTable));
}
+ //TODO Create a ticket to get rid of future because physical table must
exists if we found catalog version, where table is alive.
Review Comment:
let's create ticked and mention in TODO before merge
##########
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/commands/RemoveIndexCommand.java:
##########
@@ -58,7 +57,11 @@ private RemoveIndexCommand(int indexId) {
@Override
public List<UpdateEntry> get(Catalog catalog) {
- CatalogIndexDescriptor index = indexOrThrow(catalog, indexId);
+ CatalogIndexDescriptor index = catalog.index(indexId);
+
+ if (index == null) {
Review Comment:
tbh, I don't quite understand why index may be null at this point... It
worth to add a comment
##########
modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItCreateTableDdlTest.java:
##########
@@ -340,24 +335,4 @@ public void
testItIsNotPossibleToCreateTablesInSystemSchema(String schema) {
private static Stream<Arguments> reservedSchemaNames() {
return SYSTEM_SCHEMAS.stream().map(Arguments::of);
}
-
- @Disabled("https://issues.apache.org/jira/browse/IGNITE-20680";)
- @Test
- public void concurrentDrop() {
Review Comment:
I think, the test actually rather useful, we only need to start RO
transaction explicitly and use it within the loop. In that way we will be
checking exactly behaviour which is described in pp1-3 in your justification.
WDYT?
PS. I would also insert some rows and validate the result on every iteration
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
