tkalkirill commented on code in PR #3262:
URL: https://github.com/apache/ignite-3/pull/3262#discussion_r1499265040
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/PartitionListener.java:
##########
@@ -612,23 +607,17 @@ private void markFinished(UUID txId, boolean commit,
@Nullable HybridTimestamp c
));
}
- // TODO: IGNITE-21560 Add schema sync to
BuildIndexCommand#startBuildingCatalogVersion
- // TODO: IGNITE-21560 Skip command if index was removed
private BuildIndexRowVersionChooser
createBuildIndexRowVersionChooser(BuildIndexCommand command) {
- int creationCatalogVersion = command.creationCatalogVersion();
- Catalog creationIndexCatalog =
catalogService.catalog(creationCatalogVersion);
+ int creationIndexCatalogVersion = command.creationCatalogVersion();
Review Comment:
fix it
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/PartitionListener.java:
##########
@@ -612,23 +607,17 @@ private void markFinished(UUID txId, boolean commit,
@Nullable HybridTimestamp c
));
}
- // TODO: IGNITE-21560 Add schema sync to
BuildIndexCommand#startBuildingCatalogVersion
- // TODO: IGNITE-21560 Skip command if index was removed
private BuildIndexRowVersionChooser
createBuildIndexRowVersionChooser(BuildIndexCommand command) {
- int creationCatalogVersion = command.creationCatalogVersion();
- Catalog creationIndexCatalog =
catalogService.catalog(creationCatalogVersion);
+ int creationIndexCatalogVersion = command.creationCatalogVersion();
+ Catalog creationIndexCatalog =
catalogService.catalog(creationIndexCatalogVersion);
Review Comment:
fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
