kgusakov commented on code in PR #3225:
URL: https://github.com/apache/ignite-3/pull/3225#discussion_r1506390478
##########
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/rebalance/RebalanceRaftGroupEventsListener.java:
##########
@@ -413,6 +510,14 @@ private void
doOnNewPeersConfigurationApplied(PeersAndLearners configuration) {
retryPreconditions = and(retryPreconditions, con5);
}
+ retryPreconditions = and(
+ or(
+
notExists(stableChangeTriggerKey(tablePartitionId)),
+
value(stableChangeTriggerKey(tablePartitionId)).lt(ByteUtils.longToBytes(revision))
Review Comment:
So, if this condition failed, we will produce the failCase result and
schedule new attempt? I think that's not right - we should produce the new
result about the stale update and do nothing then. The same trick we already
use here
https://github.com/apache/ignite-3/blob/c9b1ab9cebed8fc04db90abf18b30f7f0bafb090/modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/rebalance/RebalanceUtil.java#L191
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
