denis-chudov commented on code in PR #3219: URL: https://github.com/apache/ignite-3/pull/3219#discussion_r1507684353
########## modules/transactions/src/main/java/org/apache/ignite/internal/tx/message/CloseCursorsBatchMessage.java: ########## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.tx.message; + +import java.util.Collection; +import java.util.UUID; +import org.apache.ignite.internal.network.annotations.Transferable; +import org.apache.ignite.internal.replicator.message.TimestampAware; + +/** + * Close transaction cursors message. + */ +@Transferable(TxMessageGroup.TX_CLOSE_CURSORS) +public interface CloseCursorsBatchMessage extends TimestampAware { + + /** + * Retrieves a collection of transaction UUIDs. + * + * @return a collection of transaction UUIDs Review Comment: ```suggestion * @return A collection of transaction UUIDs. ``` ########## modules/transactions/src/main/java/org/apache/ignite/internal/tx/impl/ClosedTransactionTracker.java: ########## @@ -0,0 +1,93 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.tx.impl; + +import static java.util.concurrent.CompletableFuture.allOf; +import static java.util.stream.Collectors.toSet; + +import java.util.Set; +import java.util.UUID; +import java.util.concurrent.CompletableFuture; +import java.util.concurrent.ConcurrentHashMap; +import org.apache.ignite.internal.network.MessagingService; +import org.apache.ignite.internal.network.NetworkMessage; +import org.apache.ignite.internal.tx.message.CloseCursorsBatchMessage; +import org.apache.ignite.internal.tx.message.TxMessagesFactory; +import org.apache.ignite.network.ClusterNode; +import org.apache.ignite.network.TopologyService; + +/** + * Keeps track of all closed RO transactions. + */ +public class ClosedTransactionTracker { + + private static final int maxClosedTransactionsInBatch = 10_000; Review Comment: should be upper case ########## modules/transactions/src/main/java/org/apache/ignite/internal/tx/impl/ClosedTransactionTracker.java: ########## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.tx.impl; + +import static java.util.concurrent.CompletableFuture.allOf; +import static java.util.stream.Collectors.toSet; + +import java.util.Set; +import java.util.UUID; +import java.util.concurrent.CompletableFuture; +import java.util.concurrent.ConcurrentHashMap; +import org.apache.ignite.internal.network.MessagingService; +import org.apache.ignite.internal.network.NetworkMessage; +import org.apache.ignite.internal.tx.message.CloseCursorsBatchMessage; +import org.apache.ignite.internal.tx.message.TxMessagesFactory; +import org.apache.ignite.network.ClusterNode; +import org.apache.ignite.network.TopologyService; + +/** + * Keeps track of all closed RO transactions. + */ +public class ClosedTransactionTracker { Review Comment: In fact, it works only with RO transactions. Maybe rename it to ClosedReadOnlyTransactionTracker? ########## modules/transactions/src/main/java/org/apache/ignite/internal/tx/impl/ClosedTransactionTracker.java: ########## @@ -0,0 +1,93 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.tx.impl; + +import static java.util.concurrent.CompletableFuture.allOf; +import static java.util.stream.Collectors.toSet; + +import java.util.Set; +import java.util.UUID; +import java.util.concurrent.CompletableFuture; +import java.util.concurrent.ConcurrentHashMap; +import org.apache.ignite.internal.network.MessagingService; +import org.apache.ignite.internal.network.NetworkMessage; +import org.apache.ignite.internal.tx.message.CloseCursorsBatchMessage; +import org.apache.ignite.internal.tx.message.TxMessagesFactory; +import org.apache.ignite.network.ClusterNode; +import org.apache.ignite.network.TopologyService; + +/** + * Keeps track of all closed RO transactions. + */ +public class ClosedTransactionTracker { + + private static final int maxClosedTransactionsInBatch = 10_000; + + private static final long RPC_TIMEOUT = 3000; + + /** Tx messages factory. */ + private static final TxMessagesFactory FACTORY = new TxMessagesFactory(); + + private final Set<UUID> closedTransactions = ConcurrentHashMap.newKeySet(); + + /** + * Topology service. + */ Review Comment: ```suggestion /** Topology service. */ ``` ########## modules/transactions/src/test/java/org/apache/ignite/internal/tx/impl/ReadOnlyTransactionImplTest.java: ########## @@ -36,12 +36,22 @@ class ReadOnlyTransactionImplTest extends BaseIgniteAbstractTest { @Mock private TxManagerImpl txManager; + @Mock + private ResourceCleanupManager resourceCleanupManager; + @Test void effectiveSchemaTimestampIsReadTimestamp() { HybridTimestamp readTimestamp = new HybridClockImpl().now(); UUID txId = TestTransactionIds.TRANSACTION_ID_GENERATOR.transactionIdFor(readTimestamp); - var tx = new ReadOnlyTransactionImpl(txManager, new HybridTimestampTracker(), txId, "localId", readTimestamp); + var tx = new ReadOnlyTransactionImpl( Review Comment: What do you think about adding additional tests checking that RO transaction's cursors are closed after its finish? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
