rpuch commented on code in PR #3326:
URL: https://github.com/apache/ignite-3/pull/3326#discussion_r1508835737
##########
modules/network/src/main/java/org/apache/ignite/internal/network/netty/ConnectionManager.java:
##########
@@ -105,8 +107,7 @@ public class ConnectionManager implements
ChannelCreationListener {
/** Node consistent id. */
private final String consistentId;
- /** Node launch id. As opposed to {@link #consistentId}, this identifier
changes between restarts. */
- private final UUID launchId;
+ private volatile @Nullable ClusterNode localNode;
Review Comment:
Before building that ClusterNode, we need to start the ConnectionManager to
obtain a bound server socket from which we take local address, and then apply
some transformations to it. The starting is made in the `start()` method. So
the field cannot be final.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
