ibessonov commented on code in PR #3325:
URL: https://github.com/apache/ignite-3/pull/3325#discussion_r1510702309
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/snapshot/PartitionAccess.java:
##########
@@ -197,4 +198,20 @@ public interface PartitionAccess {
* @throws StorageRebalanceException If there are errors when trying to
finish rebalancing.
*/
CompletableFuture<Void> finishRebalance(long lastAppliedIndex, long
lastAppliedTerm, RaftGroupConfiguration raftGroupConfig);
+
+ /**
+ * Returns the row ID for which the index needs to be built, {@code null}
means that the index building has completed.
+ *
+ * @param indexId Index ID of interest.
+ * @throws StorageException If failed to get the row ID.
+ */
+ @Nullable RowId getNextRowIdToBuildIndex(int indexId);
Review Comment:
Is this method ever used?
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/snapshot/message/SnapshotMetaResponse.java:
##########
@@ -22,9 +22,7 @@
import org.apache.ignite.internal.table.distributed.TableMessageGroup;
import org.apache.ignite.raft.jraft.entity.RaftOutter.SnapshotMeta;
-/**
- * Snapshot meta response message.
- */
+/** Snapshot meta response message. */
Review Comment:
Why did you do this? Please explain, this comment was absolutely fine, and
you didn't change anything else in the file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
