AMashenkov commented on code in PR #3340:
URL: https://github.com/apache/ignite-3/pull/3340#discussion_r1510942518
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/LowWatermark.java:
##########
@@ -68,15 +72,15 @@ public class LowWatermark implements ManuallyCloseable {
private final VaultManager vaultManager;
- private final MvGc mvGc;
+ private final List<LowWatermarkChangedListener> updateListeners = new
CopyOnWriteArrayList<>();
Review Comment:
LowWatermark produces a single event type, while EventProducer supports
multiple types.
EventProducer requires creating a enum for Event type, an Event class for
event objects, which provides a factory method for EventParameters. All this
stuff is required just for passing a HybridTimestamp.
I think DRY principle is overkill here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
