tkalkirill commented on code in PR #3345:
URL: https://github.com/apache/ignite-3/pull/3345#discussion_r1512231273
##########
modules/network/src/main/java/org/apache/ignite/internal/network/recovery/RecoveryClientHandshakeManager.java:
##########
@@ -169,6 +171,30 @@ public void onInit(ChannelHandlerContext handlerContext) {
this.handler = (HandshakeHandler) ctx.handler();
}
+ @Override
+ public void onConnectionOpen() {
+ // Sending a probe to make sure we detect a channel that ends up in a
strange state upon creation:
+ // the client sees it as a normally open channel, but the server (at
least, Netty) did inot even notice that it accepted it.
Review Comment:
```suggestion
// the client sees it as a normally open channel, but the server (at
least, Netty) did not even notice that it accepted it.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
