ibessonov commented on code in PR #3341:
URL: https://github.com/apache/ignite-3/pull/3341#discussion_r1512252098
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -1275,11 +1282,16 @@ private CompletableFuture<Void> createTableLocally(
startedTables.put(tableId, table);
- return allOf(localPartsUpdateFuture, tablesByIdFuture)
- .thenComposeAsync(ignore -> inBusyLock(
- busyLock,
- () ->
startLocalPartitionsAndClients(assignmentsFuture, table, zoneDescriptor.id())
- ), ioExecutor);
+ return allOf(localPartsUpdateFuture,
tablesByIdFuture).thenComposeAsync(ignore -> inBusyLock(busyLock, () -> {
+ if (onNodeRecovery) {
Review Comment:
Are you sure that we only do this on recovery?
How are we creating PK index on new table then? This code looks suspicious.
##########
modules/index/src/main/java/org/apache/ignite/internal/index/IndexManager.java:
##########
@@ -181,7 +149,7 @@ public void stop() throws Exception {
* parameters.
*/
CompletableFuture<MvTableStorage> getMvTableStorage(long causalityToken,
int tableId) {
- return tableStoragesVv.get(causalityToken).thenApply(ignore ->
tableStoragesById.get(tableId));
+ return tableManager.tableAsync(causalityToken,
tableId).thenApply(table -> table.internalTable().storage());
Review Comment:
I believe that this method no longer belongs to `IndexManager` and you could
remove it, but if that's an unrelated change then we can do it later. What's
you opinion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
