rpuch commented on code in PR #3342:
URL: https://github.com/apache/ignite-3/pull/3342#discussion_r1512904470
##########
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogManagerImpl.java:
##########
@@ -158,6 +158,7 @@ public CatalogManagerImpl(
this.clockWaiter = clockWaiter;
this.delayDurationMsSupplier = delayDurationMsSupplier;
this.partitionIdleSafeTimePropagationPeriodMsSupplier =
partitionIdleSafeTimePropagationPeriodMsSupplier;
+ this.clock = new HybridClockImpl();
Review Comment:
The clock must be injected, not instantiated here
##########
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogManagerImpl.java:
##########
@@ -446,9 +447,9 @@ private CompletableFuture<Integer>
saveUpdate(UpdateProducer updateProducer, int
public List<SystemView<?>> systemViews() {
return List.of(
createSystemViewsView(),
- createSystemViewColumnsView(),
- createSystemViewZonesView(),
- createSystemViewIndexesView()
+ createColumnsView(),
Review Comment:
It seems that `createSystemViewColumnsView` was a correct name as it was a
view presenting columns of system views.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
