tkalkirill commented on code in PR #3352:
URL: https://github.com/apache/ignite-3/pull/3352#discussion_r1516122669
##########
modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/PersistentPageMemoryStorageEngine.java:
##########
@@ -171,22 +191,36 @@ public CompletableFuture<?>
onCreate(ConfigurationNotificationEvent<PersistentPa
return nullCompletedFuture();
}
});
+
+ // TODO: remove this executor, see
https://issues.apache.org/jira/browse/IGNITE-21683
+ destructionExecutor = new ThreadPoolExecutor(
+ 0,
+ Runtime.getRuntime().availableProcessors(),
+ 100,
Review Comment:
I think we can kill the threads as soon as they are no longer needed, why
are they kept?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
