AMashenkov commented on code in PR #2203:
URL: https://github.com/apache/ignite-3/pull/2203#discussion_r1519546475
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/TableRowConverterImpl.java:
##########
@@ -115,15 +80,7 @@ public class TableRowConverterImpl implements
TableRowConverter {
public <RowT> BinaryRowEx toBinaryRow(ExecutionContext<RowT> ectx, RowT
row, boolean key) {
BinaryTuple binaryTuple = ectx.rowHandler().toBinaryTuple(row);
- if (!key) {
- InternalTuple tuple =
schemaDescriptor.physicalOrderMatchesLogical()
- ? binaryTuple
- : new FormatAwareProjectedTuple(binaryTuple, fullMapping);
-
- return SqlOutputBinaryRow.newRow(schemaDescriptor.version(),
fullRowColocationIndexes, colocationColumnTypes, tuple);
- } else {
- return SqlOutputBinaryRow.newRow(schemaDescriptor.version(),
keyOnlyColocationIndexes, colocationColumnTypes, binaryTuple);
- }
+ return SqlOutputBinaryRow.newRow(schemaDescriptor, key, binaryTuple);
Review Comment:
Is it possible to get rid of `boolean key` flag?
Having a special method usually better than using a flag, when the caller
always knows the case.
It is ok to do in a separate ticket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
