denis-chudov commented on code in PR #3401:
URL: https://github.com/apache/ignite-3/pull/3401#discussion_r1524801714
##########
modules/placement-driver/src/main/java/org/apache/ignite/internal/placementdriver/negotiation/LeaseNegotiator.java:
##########
@@ -42,7 +41,11 @@ public class LeaseNegotiator {
private static final PlacementDriverMessagesFactory
PLACEMENT_DRIVER_MESSAGES_FACTORY = new PlacementDriverMessagesFactory();
- /** Leases ready to accept. */
+ static LeaseGrantedMessageResponse NOT_ACCEPTED_RESPONSE =
PLACEMENT_DRIVER_MESSAGES_FACTORY.leaseGrantedMessageResponse()
Review Comment:
The `null` in the undefined agreement is a lease. We already have a lease in
the pending agreement, what we need is to complete the future of the agreement,
i.e. to make it `ready` in order to let LeaseUpdater select the new candidate.
The readiness of the agreement doesn't depend on whether the lease is null or
not
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
