rpuch commented on code in PR #3424:
URL: https://github.com/apache/ignite-3/pull/3424#discussion_r1527996494
##########
modules/catalog/src/test/java/org/apache/ignite/internal/catalog/CatalogManagerSelfTest.java:
##########
@@ -217,6 +217,22 @@ public void testEmptyCatalog() {
assertThat(manager.latestCatalogVersion(), is(0));
}
+ @Test
+ public void assignsSuccessiveCatalogVersions() {
+ CompletableFuture<Integer> version1Future =
manager.execute(simpleTable(TABLE_NAME));
+ assertThat(version1Future, willCompleteSuccessfully());
Review Comment:
There is a test that checks explicitly that `execute()` returns successive
version numbers. Non of other tests actually needs to know the completion
value, it's enough to verify that the future completes with any value. If I add
that, this will make the test very rigid for no reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
