Cyrill commented on code in PR #3436:
URL: https://github.com/apache/ignite-3/pull/3436#discussion_r1532188796
##########
modules/transactions/src/main/java/org/apache/ignite/internal/tx/impl/TransactionInflights.java:
##########
@@ -99,6 +99,15 @@ public void removeInflight(UUID txId) {
tuple.onInflightsRemoved();
}
+ /**
+ * Cleanup tx inflights on tx finish.
+ *
+ * @param txId Transaction id.
+ */
+ void clearInflights(UUID txId) {
Review Comment:
I agree that the naming is utterly confusing.
WDYT of renaming `TransactionInflights` to `TransactionContextManager` or
`TransactionContexts`, `addInflight`/`removeInflight` will remain the same or
we can rename them to `registerRequest`/`unregisterRequest`.
Both existing `removeTxContexts` and `clearInflights` will become
`removeTxContext(s)` or `clearTxContext(s)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
