rpuch commented on code in PR #3451:
URL: https://github.com/apache/ignite-3/pull/3451#discussion_r1533652053


##########
modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/index/AbstractRocksDbIndexStorage.java:
##########
@@ -222,15 +223,15 @@ String createStorageInfo() {
      * @throws RocksDBException If failed to delete data.
      */
     public final void destroyData(WriteBatch writeBatch) throws 
RocksDBException {
-        destroyData0(writeBatch);
+        clearIndex(writeBatch);
 
         indexMetaStorage.removeNextRowIdToBuild(writeBatch, indexId, 
helper.partitionId());
 
-        nextRowIdToBuild = RowId.lowestRowId(helper.partitionId());
+        nextRowIdToBuild = initialRowIdToBuild(helper.partitionId());
     }
 
-    /** Methods that needs to be overridden by the inheritors to destroy 
implementation specific data. */
-    abstract void destroyData0(WriteBatch writeBatch) throws RocksDBException;
+    /** Methods that needs to be overridden by the inheritors to remove all 
implementation specific data for this index. */

Review Comment:
   'Methods' or 'Method'?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to