tkalkirill commented on code in PR #3478:
URL: https://github.com/apache/ignite-3/pull/3478#discussion_r1537427956
##########
modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/mv/PersistentPageMemoryMvPartitionStorage.java:
##########
@@ -351,32 +351,15 @@ protected List<AutoCloseable> getResourcesToClose() {
/**
* Syncs and saves meta-information on checkpoint.
*
- * @param executor Executor for asynchronous data synchronization.
- * @throws IgniteInternalCheckedException If failed.
+ * @param executor Executor for asynchronous data synchronization, {@code
null} if absent.
*/
- private void syncMetadataOnCheckpoint(@Nullable Executor executor) throws
IgniteInternalCheckedException {
+ private void syncMetadataOnCheckpoint(@Nullable Executor executor) {
RenewablePartitionStorageState localState = renewableState;
if (executor == null) {
- localState.rowVersionFreeList().saveMetadata();
-
- localState.indexFreeList().saveMetadata();
+ saveFreeListsMetadata(localState);
} else {
- executor.execute(() -> {
- try {
- localState.rowVersionFreeList().saveMetadata();
- } catch (IgniteInternalCheckedException e) {
- throw new StorageException("Failed to save
RowVersionFreeList metadata", e);
- }
- });
-
- executor.execute(() -> {
- try {
- localState.indexFreeList().saveMetadata();
- } catch (IgniteInternalCheckedException e) {
- throw new StorageException("Failed to save
IndexColumnsFreeList metadata", e);
- }
- });
+ executor.execute(() -> saveFreeListsMetadata(localState));
Review Comment:
Fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
