sanpwc commented on code in PR #3492:
URL: https://github.com/apache/ignite-3/pull/3492#discussion_r1541326095
##########
modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaManager.java:
##########
@@ -511,10 +513,12 @@ private CompletableFuture<Replica> startReplicaInternal(
CompletableFuture<Replica> replicaFuture =
replicas.compute(replicaGrpId, (k, existingReplicaFuture) -> {
if (existingReplicaFuture == null ||
existingReplicaFuture.isDone()) {
assert existingReplicaFuture == null ||
isCompletedSuccessfully(existingReplicaFuture);
+ LOG.info("Replica is started [replicationGroupId={}].",
replicaGrpId);
return completedFuture(newReplica);
} else {
existingReplicaFuture.complete(newReplica);
+ LOG.info("Replica is started, existing waiter was completed
[replicationGroupId={}].", replicaGrpId);
Review Comment:
Rephrased.
##########
modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaManager.java:
##########
@@ -779,6 +780,18 @@ private void idleSafeTimeSync() {
* @return True if the replica is started.
*/
public boolean isReplicaStarted(ReplicationGroupId replicaGrpId) {
+ CompletableFuture<Replica> replicaFuture = replicas.get(replicaGrpId);
+ return replicaFuture != null && isCompletedSuccessfully(replicaFuture);
+ }
+
+ /**
+ * Check if replica was touched by an any actor. Touched here means either
replica replica creation or replica waiter registration.
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
