lowka commented on code in PR #3501:
URL: https://github.com/apache/ignite-3/pull/3501#discussion_r1541414969
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/ddl/DdlSqlToCommandConverter.java:
##########
@@ -322,31 +321,22 @@ private CreateTableCommand
convertCreateTable(IgniteSqlCreateTable createTblNode
+ "querySql=\"" + ctx.query() + "\"]");
}
- // TODO: https://issues.apache.org/jira/browse/IGNITE-21673 Remove
dedupSetPk after this issue is fixed.
- Set<String> dedupSetPk;
List<String> pkColumns;
Review Comment:
I think it is better to use this variable directly (assign pkColumns = new
ArrayList<>(columnNodes.size());)
since it is not used in any conditional logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
