nizhikov commented on code in PR #11293: URL: https://github.com/apache/ignite/pull/11293#discussion_r1546092282
########## modules/core/src/main/java/org/apache/ignite/metric/MetricRegistry.java: ########## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.metric; + +import java.util.function.BooleanSupplier; +import java.util.function.DoubleSupplier; +import java.util.function.IntSupplier; +import java.util.function.LongSupplier; +import java.util.function.Supplier; +import org.apache.ignite.lang.IgniteExperimental; +import org.apache.ignite.spi.metric.ReadOnlyMetricRegistry; +import org.jetbrains.annotations.Nullable; + +/** + * Metric registry. Allows to get, add or remove metrics. + * + * @see IgniteMetrics + * @see ReadOnlyMetricRegistry + */ +@IgniteExperimental +public interface MetricRegistry extends ReadOnlyMetricRegistry { + /** + * Registers an int metric which value will be queried from the specified supplier. + * + * @param name Metric name. + * @param supplier Metric value supplier. + * @param desc Metric description. + */ + void register(String name, IntSupplier supplier, @Nullable String desc); + + /** + * Registers a long which value will be queried from the specified supplier. Review Comment: nit: Registers a long **metric** which value. "metric" word lost -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
