sanpwc commented on code in PR #3467:
URL: https://github.com/apache/ignite-3/pull/3467#discussion_r1547822921
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java:
##########
@@ -2646,8 +2649,14 @@ private CompletableFuture<CompletableFuture<?>>
applyUpdateCommand(
applyCmdWithExceptionHandling(cmd, resultFuture);
return resultFuture.thenApply(res -> {
- // This check guaranties the result will never be lost.
Currently always null.
- assert res == null : "Replication result is lost";
+ // This check guaranties the result will never be lost.
+ assert res != null : "Replication result is lost";
+
+ UpdateCommandResult updateCommandResult =
(UpdateCommandResult) res;
+
+ if (full &&
!updateCommandResult.isPrimaryReplicaSuccess()) {
Review Comment:
Why not to throw the exception if it's not full?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
