ygerzhedovich commented on code in PR #3525:
URL: https://github.com/apache/ignite-3/pull/3525#discussion_r1548009721
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/sql/ParserServiceImplTest.java:
##########
@@ -49,54 +39,25 @@
*/
public class ParserServiceImplTest {
enum Statement {
- QUERY("SELECT * FROM my_table", SqlQueryType.QUERY, true),
- DML("INSERT INTO my_table VALUES (1, 1)", SqlQueryType.DML, true),
- DDL("CREATE TABLE my_table (id INT PRIMARY KEY, avl INT)",
SqlQueryType.DDL, false),
- EXPLAIN_QUERY("EXPLAIN PLAN FOR SELECT * FROM my_table",
SqlQueryType.EXPLAIN, false),
- EXPLAIN_DML("EXPLAIN PLAN FOR INSERT INTO my_table VALUES (1, 1)",
SqlQueryType.EXPLAIN, false);
+ QUERY("SELECT * FROM my_table", SqlQueryType.QUERY),
+ DML("INSERT INTO my_table VALUES (1, 1)", SqlQueryType.DML),
+ DDL("CREATE TABLE my_table (id INT PRIMARY KEY, avl INT)",
SqlQueryType.DDL),
+ EXPLAIN_QUERY("EXPLAIN PLAN FOR SELECT * FROM my_table",
SqlQueryType.EXPLAIN),
+ EXPLAIN_DML("EXPLAIN PLAN FOR INSERT INTO my_table VALUES (1, 1)",
SqlQueryType.EXPLAIN);
private final String text;
private final SqlQueryType type;
- private final boolean cacheable;
- Statement(String text, SqlQueryType type, boolean cacheable) {
+ Statement(String text, SqlQueryType type) {
this.text = text;
this.type = type;
- this.cacheable = cacheable;
- }
- }
-
- @ParameterizedTest
- @EnumSource(Statement.class)
- void serviceAlwaysReturnsResultFromCacheIfPresent(Statement statement) {
- ParsedResult expected = new DummyParsedResults();
-
- ParsedResult actual = new ParserServiceImpl(0, new
SameObjectCacheFactory(expected)).parse(statement.text);
-
- assertSame(actual, expected);
- }
-
- @ParameterizedTest
- @EnumSource(Statement.class)
- void serviceCachesOnlyCertainStatements(Statement statement) {
Review Comment:
could you please create a JIRA to cover it in the future
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
