ibessonov commented on code in PR #3535:
URL: https://github.com/apache/ignite-3/pull/3535#discussion_r1549721939
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/checkpoint/Checkpointer.java:
##########
@@ -340,6 +346,14 @@ void doCheckpoint() throws IgniteInternalCheckedException {
}
}
+ try {
+ logSyncer.sync();
+ } catch (Exception e) {
+ log.error("Failed to sync raft log during checkpoint
processing ", e);
Review Comment:
Please don't mention raft
##########
modules/rocksdb-common/src/main/java/org/apache/ignite/internal/rocksdb/flush/RocksDbFlushListener.java:
##########
@@ -59,6 +59,7 @@ class RocksDbFlushListener extends AbstractEventListener {
/** {@inheritDoc} */
@Override
public void onFlushBegin(RocksDB db, FlushJobInfo flushJobInfo) {
+
Review Comment:
Excuse me?
##########
modules/raft/src/main/java/org/apache/ignite/internal/raft/storage/logit/LogitLogStorageFactory.java:
##########
@@ -92,6 +92,11 @@ public void close() {
ExecutorServiceHelper.shutdownAndAwaitTermination(checkpointExecutor);
}
+ @Override
+ public void sync() {
+ // No-op.
Review Comment:
Please throw an exception instead. It's not a no-op.
##########
modules/rocksdb-common/src/main/java/org/apache/ignite/internal/rocksdb/flush/RocksDbFlusher.java:
##########
@@ -192,6 +192,14 @@ public CompletableFuture<Void> awaitFlush(boolean
schedule) {
future =
flushFuturesBySequenceNumber.computeIfAbsent(dbSequenceNumber, s -> new
CompletableFuture<>());
}
+ try {
+ db.syncWal();
Review Comment:
This is a wrong place
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
