timoninmaxim commented on code in PR #11298:
URL: https://github.com/apache/ignite/pull/11298#discussion_r1549726587
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotPartitionsVerifyHandler.java:
##########
@@ -180,6 +180,9 @@ public
SnapshotPartitionsVerifyHandler(GridCacheSharedContext<?, ?> cctx) {
return Collections.emptyMap();
}
+ if (F.isEmpty(partFiles))
+ return Collections.emptyMap();
Review Comment:
Let's add log here, that this part is filtered, possible due to node filter
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/dump/Dump.java:
##########
@@ -163,10 +163,12 @@ public Dump(
* @return Standalone kernal context.
*/
private GridKernalContext standaloneKernalContext(File dumpDir,
IgniteLogger log) {
- File binaryMeta =
CacheObjectBinaryProcessorImpl.binaryWorkDir(dumpDir.getAbsolutePath(),
F.first(metadata).folderName());
+ SnapshotMetadata meta = metadata.stream().filter(m ->
!m.partitions().isEmpty()).findFirst().orElse(F.first(metadata));
Review Comment:
Looks overcomplicated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
