ptupitsyn commented on code in PR #3562:
URL: https://github.com/apache/ignite-3/pull/3562#discussion_r1555553602
##########
modules/core/src/main/java/org/apache/ignite/internal/streamer/StreamerSubscriber.java:
##########
@@ -258,11 +254,7 @@ private void initFlushTimer() {
return;
}
- String threadPrefix = "client-data-streamer-flush-" + hashCode();
-
- flushTimer = Executors.newSingleThreadScheduledExecutor(new
NamedThreadFactory(threadPrefix, log));
-
- flushTask = flushTimer.scheduleAtFixedRate(this::flushBuffers,
interval, interval, TimeUnit.MILLISECONDS);
+ flushTask = flushExecutor.scheduleAtFixedRate(this::flushBuffers,
interval, interval, TimeUnit.MILLISECONDS);
Review Comment:
Good catch, fixed this and some other potential race conditions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
