rpuch commented on code in PR #3547:
URL: https://github.com/apache/ignite-3/pull/3547#discussion_r1555883460
##########
modules/table/src/main/java/org/apache/ignite/internal/table/AbstractTableView.java:
##########
@@ -102,13 +101,13 @@ abstract class AbstractTableView<R> implements
CriteriaQuerySource<R> {
/**
* Waits for operation completion.
*
- * @param fut Future to wait to.
+ * @param future Future to wait to.
* @param <T> Future result type.
* @return Future result.
*/
- protected final <T> T sync(Supplier<CompletableFuture<T>> fut) {
+ protected static <T> T sync(CompletableFuture<T> future) {
try {
- return fut.get().get();
+ return future.get();
Review Comment:
No, the idea was to have ability to do something before the operation starts
being executed; I know this because I introduced that indirection :) This
change just reverts it back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
