xtern commented on code in PR #3558: URL: https://github.com/apache/ignite-3/pull/3558#discussion_r1557437164
########## modules/sql-engine/src/integrationTest/sql/types/time/time_parsing.test: ########## @@ -22,8 +22,8 @@ SELECT '14:42:04.999'::TIME(3)::VARCHAR ---- 14:42:04.999 +# trailing zeros get truncated query I -SELECT '14:42:04.999'::TIME(6)::VARCHAR +SELECT '14:42:04.000000'::TIME(6)::VARCHAR Review Comment: But in general I agree, I think the comment is enough, so I did as you suggested. ########## modules/sql-engine/src/integrationTest/sql/types/time/time_parsing.test: ########## @@ -22,8 +22,8 @@ SELECT '14:42:04.999'::TIME(3)::VARCHAR ---- 14:42:04.999 +# trailing zeros get truncated query I -SELECT '14:42:04.999'::TIME(6)::VARCHAR +SELECT '14:42:04.000000'::TIME(6)::VARCHAR Review Comment: But in general I agree, I think the comment is enough, so I did as you suggested, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
