xtern commented on code in PR #3577:
URL: https://github.com/apache/ignite-3/pull/3577#discussion_r1559248441


##########
modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItSqlOperatorsTest.java:
##########
@@ -326,6 +331,25 @@ public void testJson() {
         assertExpression("'{\"a\":1}' IS NOT JSON 
OBJECT").returns(false).check();
         assertExpression("'[1, 2]' IS NOT JSON ARRAY").returns(false).check();
         assertExpression("'1' IS NOT JSON SCALAR").returns(false).check();
+
+        // TODO https://issues.apache.org/jira/browse/IGNITE-20163
+        // assertExpression("'{\"a\":1}' FORMAT JSON").check();
+    }
+
+    @Test
+    @SuppressWarnings("ThrowableNotThrown")

Review Comment:
   Fixed, thanks



##########
modules/sql-engine/src/integrationTest/sql/function/json/test_json.test:
##########
@@ -26,3 +26,28 @@ query R
 SELECT JSON_ARRAY ('test', 1, 4.2)
 ----
 ["test",1,4.2]
+
+statement ok
+create table t(id int primary key, name varchar, age int);
+
+statement ok
+insert into t values (0, 'Alex', 32), (1, 'Maria', 27);
+
+query T
+select json_object('Name': name, 'age': age) from t
+----
+{"age":32,"Name":"Alex"}
+{"age":27,"Name":"Maria"}
+
+query T
+select json_array(name, age) from t
+----
+["Alex",32]
+["Maria",27]
+
+# Note nested object construction fails with NullPointerException

Review Comment:
   Fixed, thanks



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to