ibessonov commented on code in PR #3566:
URL: https://github.com/apache/ignite-3/pull/3566#discussion_r1560918291
##########
modules/storage-api/src/testFixtures/java/org/apache/ignite/internal/storage/index/AbstractSortedIndexStorageTest.java:
##########
@@ -639,6 +678,24 @@ void testScanContractAddRowBeforeInvokeHasNext() {
assertThrows(NoSuchElementException.class, scan::next);
}
+ @Test
+ void testReadOnlyScanContractUpdateAfterScan() {
+ SortedIndexStorage indexStorage = createIndexStorage(INDEX_NAME,
ColumnType.INT32);
+
+ BinaryTupleRowSerializer serializer = new
BinaryTupleRowSerializer(indexStorage.indexDescriptor());
+
+ // Put before scan, should be visible.
+ put(indexStorage, serializer.serializeRow(new Object[]{0}, new
RowId(TEST_PARTITION)));
+
+ Cursor<IndexRow> scan = indexStorage.readOnlyScan(null, null, 0);
+
+ // Put after scan, should not be visible.
+ put(indexStorage, serializer.serializeRow(new Object[]{1}, new
RowId(TEST_PARTITION)));
+
+ assertEquals(0, serializer.deserializeColumns(scan.next())[0]);
+ assertFalse(scan::hasNext);
Review Comment:
Why not `assertFalse(scan.hasNext());`? What a strange pattern
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
