xtern commented on code in PR #3590: URL: https://github.com/apache/ignite-3/pull/3590#discussion_r1565760173
########## modules/distribution-zones/src/test/java/org/apache/ignite/internal/distributionzones/DistributionZoneManagerAlterFilterTest.java: ########## Review Comment: Unfortunately I can't figure out how to do it in "@BeforeAll" for these tests. Are you suggesting to create standalone temp "catalog manager" and save default zone name into a static variable? Please see "update" section of this PR description. I decided to leave these changes in the tests for now. ########## modules/distribution-zones/src/test/java/org/apache/ignite/internal/distributionzones/DistributionZoneManagerAlterFilterTest.java: ########## Review Comment: I decided to revert these changes and leave the use of the constant (see my previous comment). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
