dspavlov commented on code in PR #261:
URL: https://github.com/apache/ignite-extensions/pull/261#discussion_r1572305786
##########
modules/cdc-ext/src/main/java/org/apache/ignite/cdc/conflictresolve/DebugCacheVersionConflictResolverImpl.java:
##########
@@ -63,6 +63,16 @@ public DebugCacheVersionConflictResolverImpl(byte clusterId,
String conflictReso
return res;
}
+ /** @return Conflict resolve field value, or specified {@code val} if the
field not found. */
+ private Object debugValue(Object val) {
+ try {
+ return super.value(val);
+ }
+ catch (Exception e) {
+ return val;
Review Comment:
LGTM in general, Just a minor comment.
can we add java comment about logging this exception - it will be logged at
a top level?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
