ptupitsyn commented on code in PR #3640:
URL: https://github.com/apache/ignite-3/pull/3640#discussion_r1576009930
##########
modules/client/src/main/java/org/apache/ignite/internal/client/table/ClientTable.java:
##########
@@ -419,15 +435,21 @@ private <T> CompletableFuture<T> doSchemaOutInOpAsync(
CompletableFuture.allOf(schemaFut, partitionsFut)
.thenCompose(v -> {
ClientSchema schema = schemaFut.getNow(null);
- String preferredNodeName = getPreferredNodeName(provider,
partitionsFut.getNow(null), schema);
-
- // Perform the operation.
- return ch.serviceAsync(opCode,
- w -> writer.accept(schema, w),
- r -> readSchemaAndReadData(schema, r, reader,
defaultValue, responseSchemaRequired),
- preferredNodeName,
- retryPolicyOverride,
- expectNotifications);
+ String txPreferredNodeName =
getPreferredNodeName(provider, partitionsFut.getNow(null), schema);
+
+ return ClientLazyTransaction.ensureStarted(tx, ch,
txPreferredNodeName).thenCompose(unused -> {
Review Comment:
Yes, I had this in mind too, but decided to keep the protocol simple.
Ticket created: https://issues.apache.org/jira/browse/IGNITE-22090
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
