shishkovilja commented on code in PR #11324:
URL: https://github.com/apache/ignite/pull/11324#discussion_r1577606277
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/odbc/SqlListenerUtils.java:
##########
@@ -298,10 +296,6 @@ public static boolean isPlainType(Class<?> cls) {
public static int exceptionToSqlErrorCode(Throwable e) {
if (e instanceof QueryCancelledException)
return IgniteQueryErrorCode.QUERY_CANCELED;
- if (e instanceof TransactionSerializationException)
- return IgniteQueryErrorCode.TRANSACTION_SERIALIZATION_ERROR;
Review Comment:
@lordgarrish , please, check this constant. It seems to be useless too.
Let's remove it and all corresponding code, related to MVCC.
Also, please check 'transactional' exceptions in this method. They also must
be removed (if possible) because transactions and SQL are not fully compatible
without MVCC.
##########
modules/core/src/test/java/org/apache/ignite/internal/processors/cache/IgniteClientCacheStartFailoverTest.java:
##########
@@ -362,15 +360,6 @@ public void testRebalanceStateConcurrentStart() throws
Exception {
", val=" + i + ']', e);
CacheConfiguration ccfg =
cache.getConfiguration(CacheConfiguration.class);
-
- TransactionSerializationException txEx =
X.cause(e, TransactionSerializationException.class);
-
- boolean notContains = !txEx.getMessage().contains(
- "Cannot serialize transaction due to write
conflict (transaction is marked for rollback)"
Review Comment:
This message is used to throw `IgniteTxSerializationCheckedException` in
`GridCacheMapEntry#serializationError`. Both seems to be unused and must be
removed.
##########
modules/core/src/test/java/org/apache/ignite/internal/processors/cache/IgniteClientCacheStartFailoverTest.java:
##########
@@ -362,15 +360,6 @@ public void testRebalanceStateConcurrentStart() throws
Exception {
", val=" + i + ']', e);
CacheConfiguration ccfg =
cache.getConfiguration(CacheConfiguration.class);
Review Comment:
Unused code must be removed.
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/odbc/SqlListenerUtils.java:
##########
@@ -298,10 +296,6 @@ public static boolean isPlainType(Class<?> cls) {
public static int exceptionToSqlErrorCode(Throwable e) {
if (e instanceof QueryCancelledException)
return IgniteQueryErrorCode.QUERY_CANCELED;
- if (e instanceof TransactionSerializationException)
- return IgniteQueryErrorCode.TRANSACTION_SERIALIZATION_ERROR;
- if (e instanceof TransactionAlreadyCompletedException)
- return IgniteQueryErrorCode.TRANSACTION_COMPLETED;
Review Comment:
@lordgarrish , please, check this constant. It seems to be useless too.
Let's remove it and all corresponding code, related to MVCC.
Also, please check 'transactional' exceptions in this method. They also must
be removed (if possible) because transactions and SQL are not fully compatible
without MVCC.
##########
modules/core/src/test/java/org/apache/ignite/internal/processors/cache/IgniteClientCacheStartFailoverTest.java:
##########
@@ -362,15 +360,6 @@ public void testRebalanceStateConcurrentStart() throws
Exception {
", val=" + i + ']', e);
CacheConfiguration ccfg =
cache.getConfiguration(CacheConfiguration.class);
-
Review Comment:
It seems, that we swallow exception without failing test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
