sanpwc commented on code in PR #3629:
URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579859118


##########
modules/runner/src/main/java/org/apache/ignite/internal/app/IgniteImpl.java:
##########
@@ -1180,16 +1181,24 @@ private RuntimeException handleStartException(Throwable 
e) {
 
         LOG.debug(errMsg, e);
 
-        lifecycleManager.stopNode();
+        try {
+            lifecycleManager.stopNode().get();
+        } catch (Exception ex) {
+            IgniteException igniteException = new IgniteException(errMsg, ex);
+            igniteException.addSuppressed(e);
+
+            return igniteException;

Review Comment:
   I'd rather return original start exception here. May add stop one as 
suppressed. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to