JAkutenshi commented on PR #3633: URL: https://github.com/apache/ignite-3/pull/3633#issuecomment-2082434695
A comment about [a test's fix there](https://github.com/apache/ignite-3/pull/3633/commits/9aa02ec66f3b4f007be62079fcc32c1160cb59d4#diff-41a813f5e33a0cf366f3366994eb3ff5beabd7c9590a4f04b2c05903ac356586R279): before the ticket there wasn't `.join()` on [TableManager](https://github.com/apache/ignite-3/pull/3633/commits/9aa02ec66f3b4f007be62079fcc32c1160cb59d4#diff-8539b597e51096e7007250e746e696d4e16351d09c3756b4989a1c331f788eadR993-R994), but now there is and if `startReplica()` returns null -- it fails with `NPE`. In context of the test, `RepelicaManager` is mocked and then, e.g. `busyLock` is null and so on. Without the method mocking the result of `startReplica()` is null and then `.join()` faces `NPE` that leads to `TimeoutException` on the top of stacktrace. As a solution I just mocking `startReplica()` that returns completed with null-value future instead just `null`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
