AMashenkov commented on code in PR #3433:
URL: https://github.com/apache/ignite-3/pull/3433#discussion_r1584408782


##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/TableRowConverterImpl.java:
##########
@@ -59,7 +60,16 @@ public class TableRowConverterImpl implements 
TableRowConverter {
         this.schemaDescriptor = schemaDescriptor;
         this.fullTupleSchema = fullTupleSchema;
 
-        this.skipTrimming = requiredColumns == null;
+        tupleFactory = requiredColumns == null ? () ->
+                tableRow -> new BinaryTuple(schemaDescriptor.length(), 
tableRow.tupleSlice()) : new Supplier<>() {

Review Comment:
   ```suggestion
           tupleFactory = requiredColumns == null 
                   ? () -> tableRow -> new 
BinaryTuple(schemaDescriptor.length(), tableRow.tupleSlice()) 
                   : new Supplier<>() {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to