ptupitsyn commented on code in PR #11328:
URL: https://github.com/apache/ignite/pull/11328#discussion_r1591826059
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/platform/client/ClientRequestHandler.java:
##########
@@ -118,9 +121,20 @@ private ClientListenerResponse
handle0(ClientListenerRequest req) {
if (req0.isAsync(ctx)) {
IgniteInternalFuture<ClientResponse> fut = req0.processAsync(ctx);
+ if (!fut.isDone()) {
+ try {
+ // Give request a chance to be executed and response
processed by the current thread,
+ // so we can avoid any performance drops caused by async
requests execution.
+ fut.get(ASYNC_REQUEST_WAIT_TIMEOUT);
Review Comment:
Is it a good idea to block the IO thread, even for a short period?
Do we have any benchmark results for this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
