rpuch commented on code in PR #3720: URL: https://github.com/apache/ignite-3/pull/3720#discussion_r1596332708
########## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/metrics/MetaStorageMetricSource.java: ########## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.metastorage.metrics; + +import java.util.HashMap; +import org.apache.ignite.internal.metrics.LongGauge; +import org.apache.ignite.internal.metrics.Metric; +import org.apache.ignite.internal.metrics.MetricSet; +import org.apache.ignite.internal.metrics.MetricSource; +import org.jetbrains.annotations.Nullable; + +/** + * Metric source which provides MetaStorage-related metrics. + */ +public class MetaStorageMetricSource implements MetricSource { + private static final String SOURCE_NAME = "metastorage"; + + private final MetaStorageMetrics metaStorageMetrics; + + private boolean enabled; + + /** + * Constructor. + */ + public MetaStorageMetricSource(MetaStorageMetrics metaStorageMetrics) { + this.metaStorageMetrics = metaStorageMetrics; + } + + @Override + public String name() { + return SOURCE_NAME; + } + + @Override + public synchronized @Nullable MetricSet enable() { Review Comment: A metric source is enabled/disabled very rarely, so this will not create any performance problem. The easiest possible code will do, and using `synchronized` keyword seems the easiest. Moreover, this is how it's done for all sources. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
